> On May 11, 2015, 6:40 a.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java, > > line 329 > > <https://reviews.apache.org/r/34030/diff/1/?file=955135#file955135line329> > > > > I also added this block comment before the synchronized block in my > > version: > > > > /* > > * We can avoid metrics deregistration concurrency issues by > > only closing > > * one drillbit at a time. To enforce that, we synchronize on a > > convenient > > * singleton object. > > */
Sorry just committed this. Can you rebase and add your comment too? - Hanifi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34030/#review83203 ----------------------------------------------------------- On May 11, 2015, 6:37 a.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34030/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 6:37 a.m.) > > > Review request for drill, Chris Westin and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > DRILL-3022: ensure sequential shutdown of drillbits > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 531253e4245a1a4f50216359ed5591f0f1804b31 > > Diff: https://reviews.apache.org/r/34030/diff/ > > > Testing > ------- > > unit > > > Thanks, > > Hanifi Gunes > >
