----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34062/ -----------------------------------------------------------
(Updated May 11, 2015, 10:55 p.m.) Review request for drill, Jason Altekruse and Parth Chandra. Changes ------- Addressed Jason's verbal feedback. - Removed non-static list & map from BaseTestQuery updated affected test cases. - Added static listOf & mapOf methods to TestBuilder & documented - listOf & mapOf converts any CharSequence to hadoop.io.Text Repository: drill-git Description ------- DRILL-3027: Add convenience methods to test builder for creating nested baseline values Diffs (updated) ----- exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java db1ed348a7edc7c1ee3b92491e34dbce7047d27a exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 13f958c22315bf546c1eafb164bcf86c85197e66 exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java c6e81a996fa3037b9e4bafddb82d200b5d9ebcc3 exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java dfa89caed54abb871e3d2a346bd5f639d321fa06 Diff: https://reviews.apache.org/r/34062/diff/ Testing (updated) ------- TestFrameworkTest, TestJsonReader Thanks, Hanifi Gunes
