-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34063/
-----------------------------------------------------------

(Updated May 12, 2015, 12:18 a.m.)


Review request for drill, abdelhakim deneche, Jason Altekruse, Mehant Baid, and 
Venki Korukanti.


Changes
-------

Addressed Jason's comments.


Repository: drill-git


Description
-------

DRILL-2776: add extensive tests for empty population coverage


Diffs (updated)
-----

  
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/TestEmptyPopulation.java
 PRE-CREATION 
  
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/TestEmptyPopulator.java
 23cc316aac7e7d64fea2a2549a42d0a9c4d401bb 
  exec/java-exec/src/test/resources/vector/complex/map-empty-between.json 
PRE-CREATION 
  exec/java-exec/src/test/resources/vector/complex/map-empty-first.json 
PRE-CREATION 
  exec/java-exec/src/test/resources/vector/complex/map-empty-last.json 
PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/multi-repeated-list-empty-between.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/multi-repeated-list-empty-first.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/multi-repeated-list-empty-last.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/multi-repeated-list-multi-empty.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-between.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-first.json 
PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-last.json 
PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-between.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-first.json 
PRE-CREATION 
  exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-last.json 
PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-between.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-first.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-last.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/34063/diff/


Testing
-------

TestEmptyPopulation


Thanks,

Hanifi Gunes

Reply via email to