----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33995/#review83349 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On May 8, 2015, 11:54 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33995/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 11:54 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2343 > https://issues.apache.org/jira/browse/DRILL-2343 > > > Repository: drill-git > > > Description > ------- > > Overview of org.apache.drill.jdbc.proxy classes/interfaces: > > Entry point: > - TracingProxyDriver - Tracing proxy JDBC driver class. Class description > Javadoc has usage instructions. > > Other core types: > - ProxiesManager - creates and tracks java.lang.reflect.Proxy-based proxy > objects > - TracingInvocationHandler - java.lang.reflect.Proxy invocation handler; maps > reflective/proxy invocations to InvocationReporter method call/return/throw > event calls > - InvocationReporter - defines method call/return/throw event calls > - InvocationReporterImpl - implements rendering of method call/return/throw > event calls (including rendering of parameter/return/exception values). > - ProxySetupSQLException > > Unit tests: > - TracingProxyDriverClassLoadingTest - test of loading proxied driver class > - TracingProxyDriverTest - basic test of proxying (pass-through) and tracing > output > > Other: > - exec/jdbc-all/pom.xml - has change to keep TracingProxyDriver and > depended-on classes in JDBC-all Jar file. > > > Diffs > ----- > > exec/jdbc-all/pom.xml 9042769 > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/InvocationReporter.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/InvocationReporterImpl.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/ProxiesManager.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/ProxySetupSQLException.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingInvocationHandler.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/proxy/TracingProxyDriverClassLoadingTest.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/proxy/TracingProxyDriverTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33995/diff/ > > > Testing > ------- > > Ran new specific unit tests. > > Ran regular tests; no new errors. > > > Thanks, > > Daniel Barclay > >
