----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34028/#review83400 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On May 11, 2015, 6:06 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34028/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 6:06 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-3020 > https://issues.apache.org/jira/browse/DRILL-3020 > > > Repository: drill-git > > > Description > ------- > > Changed SQLException construction to set SQLException's message to the cause > exception's toString(). > > Also: > - Narrowed one SQLException to SQLNonTransientConnectionException (not other > two, since unclear whether transient, non-transient, or varied). > - Clarified/simplified exception messages. > - Fixed message typo. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 30279e6 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 30c85eb > > Diff: https://reviews.apache.org/r/34028/diff/ > > > Testing > ------- > > Manually tested in SQLLine. > > Ran regular tests; no new failures. > > > Thanks, > > Daniel Barclay > >
