> On May 14, 2015, 11:20 p.m., abdelhakim deneche wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java, > > line 809 > > <https://reviews.apache.org/r/34184/diff/2-3/?file=960663#file960663line809> > > > > actually I got confused in my previous comment. > > > > Why this unit test is inside TestDrillbitResilience ?
The purpose is to test memoryleak when exception is injected. Hopefully, it makes sense to keep it there. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34184/#review83869 ----------------------------------------------------------- On May 14, 2015, 11:14 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34184/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 11:14 p.m.) > > > Review request for drill, abdelhakim deneche, Jinfeng Ni, and Steven Phillips. > > > Bugs: DRILL-3065 > https://issues.apache.org/jira/browse/DRILL-3065 > > > Repository: drill-git > > > Description > ------- > > Clean the SelectionVector4 in mSort after failure happens > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > 529a6ca > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java > 9acae9e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java > d97ffc0 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java > f95fbe1 > > Diff: https://reviews.apache.org/r/34184/diff/ > > > Testing > ------- > > Unit test passed; Others are running > > > Thanks, > > Sean Hsuan-Yi Chu > >
