----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34255/ -----------------------------------------------------------
Review request for drill, abdelhakim deneche, Jacques Nadeau, and Sudheesh Katkam. Repository: drill-git Description ------- Currently fragment status update consists of two paths: 1) Non root fragment: which send a RPC control message 2) Root fragment: directly tries to update the status in Foreman/QueryManager, which triggers cancelling the fragments (if the root fragment status is FAILED). As part of the cancelling, it cancels itself leaving an interrupt in thread cache. After cancelling the fragments, root fragment thread also tries to write the query profile, which consumes the interrupt raised in cancellation. Issue here, root fragment does more than just state which includes cancelling itself. Until we fix the root fragment status update to be minimum, it is better to send the status through RPC control message than trying to update the state directly. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 6840cf3 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java eed4e17 Diff: https://reviews.apache.org/r/34255/diff/ Testing ------- unittests + regressions Thanks, Venki Korukanti
