> On May 29, 2015, 12:11 a.m., Parth Chandra wrote: > > Not sure why the instanceid is needed in logging. Isn't query id sufficient?
Yes, the query ID would be sufficient, but the short, sequential instance ID makes it much easier and faster to see which ResultsListener log lines are related. (It was looking at those to check how buffering and throttling was going.) - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34520/#review85654 ----------------------------------------------------------- On May 27, 2015, 5:43 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34520/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 5:43 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-3159 > https://issues.apache.org/jira/browse/DRILL-3159 > > > Repository: drill-git > > > Description > ------- > > Cleaned, enhanced DrillResultSet: > - Enhanced ResultsListener logging: > - Added instance ID; added batch numbers. > - Added logging at close (pairing with logging at construction). > - Fixed 2-integer query ID to UUID form. > - Renamed qrb -> qdb; q -> qdb (per recent QueryDataBatch change). > - Added "final" on ResultsListener's logger. > > Reduced Avatica-vs.-Drill casting: > - DrillStatementImpl's (Drill)Connection(Impl). > - DrillResultSetImpl's (Drill)Statement(Impl). > > Converted a comment in ExecConstants. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 8a24e8d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java > 6240b62 > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java > 4fa1f2f > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java > 5160c31 > > Diff: https://reviews.apache.org/r/34520/diff/ > > > Testing > ------- > > Ran existing tests. > > > Thanks, > > Daniel Barclay > >
