----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34829/#review85819 -----------------------------------------------------------
One minor optimization, then SHIP IT (non-binding) exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java <https://reviews.apache.org/r/34829/#comment137641> This variable isn't used until later, so move it to after the if block so it isn't needlessly computed. - Chris Westin On May 29, 2015, 1:44 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34829/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 1:44 p.m.) > > > Review request for drill, abdelhakim deneche, Chris Westin, and Jacques > Nadeau. > > > Bugs: DRILL-3190 > https://issues.apache.org/jira/browse/DRILL-3190 > > > Repository: drill-git > > > Description > ------- > > DRILL-3190: Check for transition from CANCELLATION_REQUESTED to non-terminal > state in FragmentData > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java > ceb77f0 > > Diff: https://reviews.apache.org/r/34829/diff/ > > > Testing > ------- > > Running unit and regresssion tests. > > > Thanks, > > Sudheesh Katkam > >
