-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
DrillPreparedStatement, DrillStatementImpl, DrillHandler]
Renamed DrillConnection.config() to more conventional getConfig().
[DrillConnection, DrillConnectionImpl]
Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
[DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
Simplified boolean Driver.load() to void. [Driver]
- Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
Wrapped lines; adjusted other whitespace.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java
6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java
PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
Diff: https://reviews.apache.org/r/35052/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
