-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35143/
-----------------------------------------------------------
(Updated June 5, 2015, 8:52 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-3216
https://issues.apache.org/jira/browse/DRILL-3216
Repository: drill-git
Description
-------
Many-instance changes: [DatabaseMetaDataGetColumnsTest]
- Renamed "...opt..." columns and methods to match "...mdrOpt" variables.
- Renamed "...req..." columns and methods to match "...mdrReq" variables.
- Renamed "testRow..." variables to "mdrUnk".
- Edited "nullability code" -> "nullability code:".
Renamed "type" -> "relDataType"; "sqlType" -> "sqlTypeName".
Changed "dfs_test.tmp" -> VIEW_SCHEMA.
Re-aligned query SQL.
Added 2 "final".
Edited 3253 (test plugin) TODOs.
Purged several comments.
Wrapped some lines.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java
39b4f3e
exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java
a4fccf6
Diff: https://reviews.apache.org/r/35143/diff/
Testing
-------
[TBD]
Thanks,
Daniel Barclay
