One quick question: you have one single commit per patch right ? On Tue, Jun 9, 2015 at 11:58 AM, Hanifi Gunes <[email protected]> wrote:
> Rebase your patch on top of master. Take a diff against master and upload > it. This should do it. Good luck. > > -Hanifi > > > On Mon, Jun 8, 2015 at 7:32 PM, Matt Burgess <[email protected]> wrote: > > > I apologize, I've been trying to get an update to my patch for DRILL-3199 > > reviewed, but I seem to be screwing up how to update the diff at > > reviews.apache.org. > > > > Should the updates be incremental commits/patches, or should they be > diffs > > against the target branch entirely? Ive tried both but either got > something > > wrong with generating the patch from Git commits, or something wrong with > > submitting them to the review. > > > > Thanks in advance, > > Matt > > > -- Abdelhakim Deneche Software Engineer <http://www.mapr.com/> Now Available - Free Hadoop On-Demand Training <http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>
