> On June 9, 2015, 8:59 p.m., Parth Chandra wrote: > > I would remove the 'empty' new files in this and other patches.
Hmm. They aren't really empty files. Weirdness in Review Board? Bad base patch for Review Board? (Checking/re-making/re-uploading patch and base patch.) - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35050/#review87295 ----------------------------------------------------------- On June 4, 2015, 6:43 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35050/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 6:43 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2089 > https://issues.apache.org/jira/browse/DRILL-2089 > > > Repository: drill-git > > > Description > ------- > > Purged interim "public" from earlier partial DRILL-2089 fixes. > Purged other "public" qualifiers no longer needed. > > > Diffs > ----- > > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java > cb6bd1d > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java > 6610f52 > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java > e095c42 > > Diff: https://reviews.apache.org/r/35050/diff/ > > > Testing > ------- > > Ran existing tests. (With parts 1 through 7 together.) > > > Thanks, > > Daniel Barclay > >
