> On June 9, 2015, 9:02 p.m., Parth Chandra wrote: > > Same comment as previous review about removing empty files.
Same reply re checking/re-making/re-uploading patch and base patch. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35051/#review87296 ----------------------------------------------------------- On June 9, 2015, 10:10 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35051/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 10:10 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2089 > https://issues.apache.org/jira/browse/DRILL-2089 > > > Repository: drill-git > > > Description > ------- > > Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name > "DrillPreparedStatement" is reserved for Drill subinterface of > PreparedStatement). > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35051/diff/ > > > Testing > ------- > > Ran existing tests. (With parts 1 through 7 together.) > > > Thanks, > > Daniel Barclay > >
