-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35636/
-----------------------------------------------------------
(Updated June 19, 2015, 8:23 p.m.)
Review request for drill, Hanifi Gunes and Mehant Baid.
Changes
-------
Removed extra second check; fixed unintended comment/parentheses spacing.
Bugs: DRILL-2447
https://issues.apache.org/jira/browse/DRILL-2447
Repository: drill-git
Description
-------
Extended coverage from just selected methods to all methods. Added wrapper
methods checking state before delegating. (Couldn't implement at just a few
choke points because Avatica makes them private and doesn't provide hooks.)
[DrillResultSetImpl]
Defined DrillResultSet.getQueryId() to throw SQLException as other methods do.
[DrillResultSet]
Re-enabled ResultSet test methods. (Also re-enabled other test methods that
pass now with DRILL-2782 changes. [Drill2489CallsAfterCloseThrowExceptionsTest]
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java e0a7763
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
d7fafe9
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
0e37efa
Diff: https://reviews.apache.org/r/35636/diff/
Testing
-------
Enabled pre-written specific unit tests.
Ran existing tests; no new failures.
Thanks,
Daniel Barclay
