-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35634/
-----------------------------------------------------------

(Updated June 19, 2015, 11:18 p.m.)


Review request for drill, abdelhakim deneche and Parth Chandra.


Changes
-------

Addressing Parth's comment: removed deprecated method altogether

+ Additional doc fixes in UserException


Summary (updated)
-----------------

DRILL-3319: UserExceptions should be logged from the right class


Bugs: DRILL-3319
    https://issues.apache.org/jira/browse/DRILL-3319


Repository: drill-git


Description (updated)
-------

DRILL-3319: Replaced UserException#build() method with #build(Logger) method to 
log from the correct class

+ Fixed docs in UserException
+ Created loggers, and changed logger visibility to private


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/exceptions/UserException.java 
6f28a2b 
  
common/src/test/java/org/apache/drill/common/exceptions/TestUserException.java 
151b762 
  
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java
 9f63e05 
  exec/java-exec/src/main/codegen/templates/ListWriters.java ab78603 
  
exec/java-exec/src/main/java/org/apache/drill/exec/client/PrintingResultsListener.java
 f5a119d 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AggregateErrorFunctions.java
 8161a43 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 
1cbe886 
  
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java
 157d550 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 
da73185 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
 e1b5909 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
 b252971 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
 9991404 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
 5ce63fb 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
 8b95f0b 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
 73aeec6 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
 655e135 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
 2866b8c 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
 5e685c8 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java
 676dcba 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java
 5924c7e 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java
 c96dc73 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java
 055b761 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
 3edcdb2 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
 0a3393e 
  
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
 ff53052 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java 
2ebd353 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 9ca09a1 
  
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
 8443948 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 
6afce1a 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedRunnable.java 
5a35aff 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
 b1135d0 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
 0df6227 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java
 fec0ab4 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
 da480d7 
  
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
 260ebde 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 
78c438b 
  
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
 a9c2b6d 
  
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java
 df74f7a 

Diff: https://reviews.apache.org/r/35634/diff/


Testing
-------


Thanks,

Sudheesh Katkam

Reply via email to