> On June 23, 2015, 11:27 p.m., Aman Sinha wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java, > > line 203 > > <https://reviews.apache.org/r/35673/diff/2/?file=989815#file989815line203> > > > > It wasn't clear why you were using non-existent columns 'age' and > > 'contribution' in this test that is querying the nation table. I thought > > DRILL-3326 is about unsupported window functions that are getting masked by > > the aliasing.
That was copy-paste mistake. A new patch has addressed that - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35673/#review89084 ----------------------------------------------------------- On June 24, 2015, 12:12 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35673/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 12:12 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3326 > https://issues.apache.org/jira/browse/DRILL-3326 > > > Repository: drill-git > > > Description > ------- > > DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig > into AS clause > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > 544a838 > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > 1c8b0db > > Diff: https://reviews.apache.org/r/35673/diff/ > > > Testing > ------- > > Unit, others are on the way > > > Thanks, > > Sean Hsuan-Yi Chu > >
