----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35851/#review89286 -----------------------------------------------------------
I don't see anything related to window functions...is this the right patch ? - Aman Sinha On June 24, 2015, 11:14 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35851/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 11:14 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3359 > https://issues.apache.org/jira/browse/DRILL-3359 > > > Repository: drill-git > > > Description > ------- > > Also detect the window frame claimed in the window definition > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java > 5e9ec93 > exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35851/diff/ > > > Testing > ------- > > unit test is done; > others are in the line > > > Thanks, > > Sean Hsuan-Yi Chu > >
