----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35808/#review89420 -----------------------------------------------------------
Ship it! Minor comments. exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java (line 118) <https://reviews.apache.org/r/35808/#comment142025> We should print nargs and change the error message since the number of arguments (incorrect) provided can be > 2. exec/java-exec/src/main/java/org/apache/drill/exec/util/ApproximateStringMatcher.java (line 29) <https://reviews.apache.org/r/35808/#comment142019> can you move the access modifiers to the front, we've been following that pattern in most of our codebase exec/java-exec/src/main/java/org/apache/drill/exec/util/ApproximateStringMatcher.java (line 73) <https://reviews.apache.org/r/35808/#comment142020> same as above exec/java-exec/src/main/java/org/apache/drill/exec/util/ApproximateStringMatcher.java (line 84) <https://reviews.apache.org/r/35808/#comment142026> Can you add unit tests? - Mehant Baid On June 24, 2015, 4:57 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35808/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 4:57 p.m.) > > > Review request for drill, Mehant Baid, Sudheesh Katkam, and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > DRILL-2862: Convert_to/Convert_From throw assertion when an incorrect > encoding type is specified or if the encoding type is not a string literal. > > Instead of an assertion when user input is wrong, we now throw an exception > with the appropriate error message. > For the case where the user types in a type name incorrectly, the error > message also provides a helpful suggestion. The suggested name is selected > from the list of available functions. > > For example: > > select convert_from(foo, 'UTF') from dfs.`/table_foo` > > will print the following error: > > Error: UNSUPPORTED_OPERATION ERROR: CONVERT_FROM does not support > conversion from type 'UTF'. > Did you mean UTF8? > [Error Id: 87ed2941-f9c2-4c35-8ff2-a3f21eae1104 on localhost:31010] > (state=,code=0) > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java > 0f8e45a > > exec/java-exec/src/main/java/org/apache/drill/exec/util/ApproximateStringMatcher.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35808/diff/ > > > Testing > ------- > > All regression tests > > > Thanks, > > Parth Chandra > >
