----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35263/ -----------------------------------------------------------
(Updated June 29, 2015, 1:22 a.m.) Review request for drill. Changes ------- Fixed unit tests to expect the correct exception Repository: drill-git Description ------- When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call. Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26 exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35263/diff/ Testing ------- Thanks, Matt Burgess
