----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35993/ -----------------------------------------------------------
Review request for drill. Repository: drill-git Description ------- When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26 exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35993/diff/ Testing ------- Implemented unit tests File Attachments ---------------- DRILL-3199.patch.4 https://reviews.apache.org/media/uploaded/files/2015/06/29/8e04f0d6-607e-410f-87de-e9f8bc901bf4__DRILL-3199.patch.4 Thanks, Matt Burgess
