----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36019/#review89828 -----------------------------------------------------------
Ship it! exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteCombineBinaryOperators.java (line 94) <https://reviews.apache.org/r/36019/#comment142636> Include the type argument here ? - Aman Sinha On June 29, 2015, 10:09 p.m., Steven Phillips wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36019/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 10:09 p.m.) > > > Review request for drill. > > > Bugs: DRILL-3418 > https://issues.apache.org/jira/browse/DRILL-3418 > > > Repository: drill-git > > > Description > ------- > > DRILL-3414: Make sure to walk entire expression tree when rewriting filter > expression for pruning > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteAsBinaryOperators.java > 44b9a3a8fbd22744f98b9b4b64c9b7aceae7587a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteCombineBinaryOperators.java > 247ad8f0fa883f6c765d94edac58d1b5e2193ddb > exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java > 48d7cebb26d2bf08baff39d6232e4829bd98d648 > > Diff: https://reviews.apache.org/r/36019/diff/ > > > Testing > ------- > > > Thanks, > > Steven Phillips > >