----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34603/#review89946 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java (line 872) <https://reviews.apache.org/r/34603/#comment142855> Can you add unit tests in TestDrillbitResilience? exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 38) <https://reviews.apache.org/r/34603/#comment142846> import org.apache.drill.exec.proto.UserBitShared.MinorFragmentProfile ? exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 158) <https://reviews.apache.org/r/34603/#comment142850> Not required? We already log the status QueryManager#fragmentStatusListener exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 216) <https://reviews.apache.org/r/34603/#comment142854> Can we log stringQueryId here? exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 262) <https://reviews.apache.org/r/34603/#comment142844> Remove static from class so you don't have to pass queryManager as an argument. exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 286) <https://reviews.apache.org/r/34603/#comment142845> space: () { exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 315) <https://reviews.apache.org/r/34603/#comment142849> Discussion: Why is this the right thing to do? Is FAILED state a fair assumption for the fragment? - Sudheesh Katkam On June 30, 2015, 6:37 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34603/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 6:37 p.m.) > > > Review request for drill, Jacques Nadeau, Jason Altekruse, and Sudheesh > Katkam. > > > Bugs: DRILL-3167 > https://issues.apache.org/jira/browse/DRILL-3167 > > > Repository: drill-git > > > Description > ------- > > - In case of a failure the Foreman will cancel all fragments and move to a > FAILING state until all fragments are terminated > - QueryManager.cancelExecutingFragments() returns false if no fragment > available > - Web UI still displays FAILED when Foreman state is FAILING > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java > 6656bf6 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java > dd26a76 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java > 9f302a2 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 716fb66 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java > 9318233 > exec/java-exec/src/main/resources/rest/profile/list.ftl cf92ede > exec/java-exec/src/main/resources/rest/profile/profile.ftl 46cdc83 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > e76d748 > protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java > 474e330 > protocol/src/main/protobuf/UserBitShared.proto 0451fd2 > > Diff: https://reviews.apache.org/r/34603/diff/ > > > Testing > ------- > > unit tests are passing > > > Thanks, > > abdelhakim deneche > >
