----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34603/#review90058 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java (line 161) <https://reviews.apache.org/r/34603/#comment142995> Doc fix: move CANCELLATION_REQUESTED to "active" list exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java (line 165) <https://reviews.apache.org/r/34603/#comment142996> Doc fix: Add case 3 here (and change the case number to 4 below). Case 3: Ignore recently finished intermediate fragment. The work bus keeps track of recently finished fragments. exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java (line 181) <https://reviews.apache.org/r/34603/#comment142999> Doc fix: (1) "Not recent" inactive intermediate fragment. (2) Inactive leaf fragment. (3) Unknown fragment. exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 233) <https://reviews.apache.org/r/34603/#comment143006> Remove TODO. SingalListener is not redundant since you have added cases that are not possible through FragmentStatusListener. exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 269) <https://reviews.apache.org/r/34603/#comment143000> Doc fix: Remove the sentence "As a result, ..." exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 306) <https://reviews.apache.org/r/34603/#comment143001> extra "," exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 316) <https://reviews.apache.org/r/34603/#comment143003> extra "," - Sudheesh Katkam On June 30, 2015, 10:37 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34603/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 10:37 p.m.) > > > Review request for drill, Jacques Nadeau, Jason Altekruse, and Sudheesh > Katkam. > > > Bugs: DRILL-3167 > https://issues.apache.org/jira/browse/DRILL-3167 > > > Repository: drill-git > > > Description > ------- > > - In case of a failure the Foreman will cancel all fragments and move to a > FAILING state until all fragments are terminated > - QueryManager.cancelExecutingFragments() returns false if no fragment > available > - Web UI still displays FAILED when Foreman state is FAILING > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java > 3e461ef > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java > 6656bf6 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java > dd26a76 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java > 9f302a2 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 716fb66 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java > 9318233 > exec/java-exec/src/main/resources/rest/profile/list.ftl cf92ede > exec/java-exec/src/main/resources/rest/profile/profile.ftl 46cdc83 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > e76d748 > protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java > 474e330 > protocol/src/main/protobuf/UserBitShared.proto 0451fd2 > > Diff: https://reviews.apache.org/r/34603/diff/ > > > Testing > ------- > > unit tests are passing along with functional and tpch100 > > > Thanks, > > abdelhakim deneche > >
