----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36103/#review90344 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java (line 97) <https://reviews.apache.org/r/36103/#comment143360> This creates the same problem I've seen elsewhere where you get two separate log events that have the same meaning. Why wouldn't you simply include this information in the Exception? I'm not seeing the upside here. Given the change in pattern to always throwing an exception, this may not even be an error since we may be just checking to see if we can allocate. - Jacques Nadeau On July 3, 2015, 2:37 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36103/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 2:37 p.m.) > > > Review request for drill, Chris Westin and Hanifi Gunes. > > > Bugs: DRILL-3445 > https://issues.apache.org/jira/browse/DRILL-3445 > > > Repository: drill-git > > > Description > ------- > > BufferAllocator.buffer(int) implementations throw an > OutOfMemoryRuntimeException instead of returning null. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17 > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java > 50ae770 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java > 016cd92 > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java > 811cceb > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java > b4386a4 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterTemplate2.java > cd2fbe9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java > d9330ea > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > 6da5582 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java > 7a7c012 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java > 4e03f11 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java > cf30db6 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java > 10bdf07 > exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java > 6337d4c > exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java > 051ad4e > > exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java > 74ce225 > > Diff: https://reviews.apache.org/r/36103/diff/ > > > Testing > ------- > > testing... > > > Thanks, > > abdelhakim deneche > >
