----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36233/#review90961 -----------------------------------------------------------
LGTM +1 (non-binding) - abdelhakim deneche On July 7, 2015, 12:42 a.m., Steven Phillips wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36233/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:42 a.m.) > > > Review request for drill. > > > Bugs: DRILL-3202 > https://issues.apache.org/jira/browse/DRILL-3202 > > > Repository: drill-git > > > Description > ------- > > DRILL-3202: Handle outer array in CountingJsonReader > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java > dfc4f3af9b3aa12e0951eb00167a993c7ad06148 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/BaseJsonProcessor.java > 78336315259e77df01738c27fd0779170c31e5fd > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/CountingJsonReader.java > c4ab1eea0543fe536b18755392a5c087fb8eaded > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java > 5c03c0281981431fe9f4f1807eb91af10f26747d > > exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java > bb1af9eb2e6ab4950c166b8057680fff175c7a3f > exec/java-exec/src/test/resources/jsoninput/countOuterArray.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/36233/diff/ > > > Testing > ------- > > > Thanks, > > Steven Phillips > >
