-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34374/
-----------------------------------------------------------
(Updated July 10, 2015, 7:33 p.m.)
Review request for drill and Steven Phillips.
Changes
-------
addressing review comments.
Bugs: DRILL-3133
https://issues.apache.org/jira/browse/DRILL-3133
Repository: drill-git
Description
-------
MergingRecordBatch stores batches in an array list before loading them with
RecordBatchLoader. If the query is canceled before all received batches are
loaded, some of the batches won't be cleaned up.
lines 307 and 339 contain questions to the reviewers. I will update the patch
accordingly
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
3ca11f1
Diff: https://reviews.apache.org/r/34374/diff/
Testing
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
