Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35053796
--- Diff:
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
---
@@ -27,11 +27,20 @@
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(FormatPluginConfigBase.class);
- public synchronized static Class<?>[] getSubTypes(DrillConfig config){
- List<String> packages =
config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
- Class<?>[] sec =
PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
- logger.debug("Adding Format Plugin Configs including {}", (Object) sec
);
- return sec;
+ public synchronized static Class<?>[] getSubTypes(DrillConfig config) {
+ List<String> packages =
+
config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
+ Class<?>[] pluginClasses =
+ PathScanner.scanForImplementationsArr(FormatPluginConfig.class,
packages);
+ if (logger.isDebugEnabled()) {
+ final StringBuilder sb = new StringBuilder();
--- End diff --
Yeah, I thought it should be factored out, but it wasn't clear where.
(Also, the functionality is close to that of some utility join(...)
methods--but not quite the same.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
