Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/81#discussion_r35810091
  
    --- Diff: 
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java ---
    @@ -119,29 +117,22 @@ public int getVarByteLength(){
       @Override
       public SerializedField getMetadata() {
         return getMetadataBuilder() //
    +             .addChild(offsetVector.getMetadata())
                  .setValueCount(getAccessor().getValueCount()) //
    -             .setVarByteLength(getVarByteLength()) //
    +//             .setVarByteLength(getVarByteLength()) //
    --- End diff --
    
    We should probably at least leave a comment as to why this was here 
originally and why it was removed and/or may re-enabled at some point. That or 
just remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to