----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37027/#review94077 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java (line 117) <https://reviews.apache.org/r/37027/#comment148578> I don't think this is the right fix. I don't see when the work list will be empty. If the source file is empty, the previous if condition is still true and we add the CompleteFileWork object to the work list. I tried to reproduce this problem on master, btw, and don't get the error reported in the JIRA. - Parth Chandra On Aug. 2, 2015, 11:53 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37027/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2015, 11:53 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-3557 > https://issues.apache.org/jira/browse/DRILL-3557 > > > Repository: drill-git > > > Description > ------- > > Ensure empty CSV's path can be added > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java > e233dda > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > e8af325 > exec/java-exec/src/test/resources/store/text/directoryWithEmpyCSV/empty.csv > PRE-CREATION > > Diff: https://reviews.apache.org/r/37027/diff/ > > > Testing > ------- > > Unit tests, functional, tpch > > > Thanks, > > Sean Hsuan-Yi Chu > >
