Github user jaltekruse commented on the pull request:

    
https://github.com/apache/drill/commit/5cd991628b79f64b681f1eb18deb5858b4264774#commitcomment-12528585
  
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java:
    In common/src/main/java/org/apache/drill/common/config/DrillConfig.java on 
line 68:
    This wasn't removing code the was previously in Drill, this is a commit 
with all of the changes made in response to review comments. I haven't seen 
these checks used very frequently, and it seemed like unnecessary optimization 
given this only happens at drillbit startup. Maybe we should just always have 
guards whenever one of the parameters includes a method call, it just didn't 
seem necessary in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to