----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37116/#review94187 -----------------------------------------------------------
Ship it! One minor comment below. exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java <https://reviews.apache.org/r/37116/#comment148726> It might be useful to keep this code in a separate function (call it checkMultipleWindows or something like that) just in case we want to use it again. - Aman Sinha On Aug. 5, 2015, 4:59 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37116/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 4:59 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3567 > https://issues.apache.org/jira/browse/DRILL-3567 > > > Repository: drill-git > > > Description > ------- > > Support multiple window definitions; Bump DrillCalcite version number to > 1.1.0-drill-r16 > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > 17689ad > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > 222c7b7 > pom.xml 3ec79e1 > > Diff: https://reviews.apache.org/r/37116/diff/ > > > Testing > ------- > > Unit, TPCH, functional > > > Thanks, > > Sean Hsuan-Yi Chu > >
