GitHub user dsbos opened a pull request:
https://github.com/apache/drill/pull/111
DRILL-3566: PreparedStatement fix and DRILL-3347: ...hadoop.io.Text fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsbos/incubator-drill
bugs/drill-3566_etc._jdbc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit aad3db5dd3787e0c0e26b42e02a2351d1d5df788
Author: dbarclay <[email protected]>
Date: 2015-07-28T02:27:50Z
DRILL-3566: Fix: PreparedStatement.executeQuery() got ClassCastException.
Main:
Restored DrillResultSetImpl(...)'s statement parameter from overly
restrictive DrillStatementImpl to AvaticaStatement and removed caller
cast that was throwing. (Relatedly, adjusted getStatement() and moved
internal casting from statement to connection.)
Added basic test of querying via PreparedStatement. [PreparedStatementTest]
Added some case test of statement-creation methods. [ConnectionTest]
commit 537f7db912f8a80088b331bde67cefbc132fae5a
Author: dbarclay <[email protected]>
Date: 2015-08-04T23:51:07Z
DRILL-3347: VARCHAR ResultSet.getObject returned ...hadoop.io.Text, not
String.
Core fix:
- Fixed {,Nullable}VarCharAccessor's getObject() to return String instead of
value vector's internal org.apache.hadoop.io.Text.
- Updated unit tests (to expect only String now).
[DatabaseMetaDataGetColumnsTest, ResultSetMetaDataTest]
Also Added getObject check in tracing proxy test. [TracingProxyDriverTest]
Changed hard references to Hadoop's Text and JodaTime's Period to strings in
warning check in tracing proxy. [InvocationReporterImpl]
Cleanup:
- Added @Override annotations. [SqlAccessors]
- (Unintentionally) fixed (undetected) missing comma.
[ValueVectorTypes.tdd]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
