> On Aug. 21, 2015, 5:44 p.m., Aman Sinha wrote: > > Is there a reason to have this rule in Drill rather than in Calcite ?
Second this. Whenever possible, we should put rule in Calcite, especially it applies to LogicalProject/LogicalWindow. - Jinfeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37697/#review96106 ----------------------------------------------------------- On Aug. 21, 2015, 3:53 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37697/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 3:53 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3412 > https://issues.apache.org/jira/browse/DRILL-3412 > > > Repository: drill-git > > > Description > ------- > > DrillPushProjectPastWindowRule to push Project past Window > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastWindowRule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > 4307757 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java > ad64ed8 > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > 29b702c > > Diff: https://reviews.apache.org/r/37697/diff/ > > > Testing > ------- > > all required > > > Thanks, > > Sean Hsuan-Yi Chu > >
