-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37685/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2489
https://issues.apache.org/jira/browse/DRILL-2489
Repository: drill-git
Description
-------
(Note: Patch depends on (needs to be applied after) patches for DRILL-3153,
-3347, -3566, and -3661.)
Refactored unit test to check all methods per interface. (Replaced individual,
static test methods with bulk reflection-based checking.)
[Drill2489CallsAfterCloseThrowExceptionsTest]
Added DrillResultSetMetaDataImpl.
Added method overrides to check state for remaining methods from Connection,
Statement, PreparedStatement, ResultSet, ResultSetMetaData and DatabaseMetaData.
Also:
- renamed checkNotClosed to throwIfClosed.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java 608bf05
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
243e627
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
9d0c132
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java
11191ae
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
86683cb
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
1b37dc1
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetMetaDataImpl.java
PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java
6cba58e
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8735146
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTransactionMethodsTest.java
1aff918
exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java 3e64fcb
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
01008b2
Diff: https://reviews.apache.org/r/37685/diff/
Testing
-------
Ran new tests in this patch. Also manually injected various errors to confirm
detection.
Ran existing tests; no new errors.
Thanks,
Daniel Barclay
