> On Aug. 25, 2015, 10:51 a.m., Aman Sinha wrote: > > Drill side changes look Ok to me. For the changes in Calcite after > > rebasing, it is difficult to compare since Drill was previously using > > Calcite 1.1.0 and many things have changed since then. The best way to > > validate the changes is to run both functional regression tests and > > performance tests (if there are plan regressions). You have already run > > the functional tests. Can we schedule a performance run ?
Run a performance test against a TPCH-SF100 workload, and did not find performance regression. - Jinfeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37721/#review96380 ----------------------------------------------------------- On Aug. 24, 2015, 10:56 a.m., Jinfeng Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37721/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 10:56 a.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > Drill uses Calcite as its SQL parser, planner, optimizer. Currently, Drill > uses a forked version of Calcite, on top of Calcite 1.1.0 release. Since the > latest of Calcite release is 1.4.0 (in voting process at this moment), Drill > should move its forked version on top of Calcite 1.4.0 release, to leverage > the new features developed in Calcite, as well as many bug fixes. > > In this patch, we are going to rebase drill's forked Calcite onto Calcite > release 1.4.0. This is similar to what we have done in Drill-1384, which > moves Drill's forked version from 0.9 to 1.1.0. > > During the rebasing process, we have identified around 10 categories of > regression failures. Those failures are addressed either in the rebased > forking Calcite libary, or in Drill side. > > We will modify the relese number to 1.4.0-drill-rx, once the patch has gone > through the review and ready for merge to Drill master branch. > > As a follow-up task, we are going to push couple of patches to Calcite master > branch in the next release, aiming to get rid of the forked version some day. > > The forked Calcite branch is currently hosted here: > > https://github.com/jinfengni/incubator-optiq/tree/DrillCalcite1.4.0 > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperator.java > 988060c > exec/java-exec/src/main/codegen/data/Parser.tdd 358b75e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java > 1dc9349 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java > 950cd87 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > 4307757 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java > 42aa728 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java > a53c242 > exec/jdbc-all/pom.xml 0e1f85d > pom.xml a4b22d7 > > Diff: https://reviews.apache.org/r/37721/diff/ > > > Testing > ------- > > JUnit test. > > Pre-commit regression suite. > > > Thanks, > > Jinfeng Ni > >
