GitHub user dsbos opened a pull request:

    https://github.com/apache/drill/pull/144

    DRILL-3347: VARCHAR ResultSet.getObject returned ...hadoop.io.Text, not 
String.

    
    Core fix:
    - Fixed {,Nullable}VarCharAccessor's getObject() to return String instead of
      value vector's internal org.apache.hadoop.io.Text.
    - Updated unit tests (to expect only String now).
      [DatabaseMetaDataGetColumnsTest, ResultSetMetaDataTest]
    
    Also Added getObject check in tracing proxy test.  [TracingProxyDriverTest]
    Changed hard references to Hadoop's Text and JodaTime's Period to strings in
    warning check in tracing proxy.  [InvocationReporterImpl]
    
    Cleanup:
    - Added @Override annotations.  [SqlAccessors]
    - (Unintentionally) fixed (undetected) missing comma.  
[ValueVectorTypes.tdd]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dsbos/incubator-drill bugs/drill-3347

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit ccd6ded4387b2b27849762f607a13fa4236351b6
Author: dbarclay <[email protected]>
Date:   2015-08-04T23:51:07Z

    DRILL-3347: VARCHAR ResultSet.getObject returned ...hadoop.io.Text, not 
String.
    
    Core fix:
    - Fixed {,Nullable}VarCharAccessor's getObject() to return String instead of
      value vector's internal org.apache.hadoop.io.Text.
    - Updated unit tests (to expect only String now).
      [DatabaseMetaDataGetColumnsTest, ResultSetMetaDataTest]
    
    Also Added getObject check in tracing proxy test.  [TracingProxyDriverTest]
    Changed hard references to Hadoop's Text and JodaTime's Period to strings in
    warning check in tracing proxy.  [InvocationReporterImpl]
    
    Cleanup:
    - Added @Override annotations.  [SqlAccessors]
    - (Unintentionally) fixed (undetected) missing comma.  
[ValueVectorTypes.tdd]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to