> On Sept. 9, 2015, 3:11 p.m., Jacques Nadeau wrote: > > Most of this looks good. Let me restate my additional request as I think > > I'm being unclear. > > > > You are currently testing tsv files (tab-delimited files). I want to you > > test the same type of conditions with another type of delimiter. For > > example, space delimited files (e.g. .ssv). This will verify that your > > solution works for multiple delimiter types.
Oh... I uploaded the previous version. Please check the latest one. (I also updated the pom file and boot-strap to make unit test recognize .ssv) - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37893/#review98199 ----------------------------------------------------------- On Sept. 9, 2015, 3:06 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37893/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 3:06 p.m.) > > > Review request for drill, Jacques Nadeau and Mehant Baid. > > > Bugs: DRILL-3718 > https://issues.apache.org/jira/browse/DRILL-3718 > > > Repository: drill-git > > > Description > ------- > > For TSV files, if the TextReader reads a double quote, it would keep scanning > until it gets the second double quote. > > However, even getting the second double quote, the current reader will keep > going in order to trim the space (i.e., ' '). > > In tsv, there is no need to trim '\t' (tab), which is used to separate fields. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java > 3899509 > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > d15cff2 > > exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java > e63e528 > exec/java-exec/src/test/resources/store/text/WithQuote.tsv PRE-CREATION > exec/java-exec/src/test/resources/store/text/WithQuoteMultiDelimiters.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/37893/diff/ > > > Testing > ------- > > All > > > Thanks, > > Sean Hsuan-Yi Chu > >
