Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r39798636
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SessionOptionManager.java
 ---
    @@ -46,6 +47,33 @@ public SessionOptionManager(final OptionManager 
systemOptions, final UserSession
       }
     
       @Override
    +  public void deleteOption(final String name, final OptionValue.OptionType 
type) {
    +    if (type == OptionValue.OptionType.SESSION) {
    +      try { // ensure option exists
    --- End diff --
    
    You only ensure the option exists when `type == SESSION`. How about 
_SYSTEM_, is it done by the underlying _fallback_ OptionManager ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to