Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/169#discussion_r40444952
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
 ---
    @@ -26,4 +30,34 @@
       public void testLimitWithExchanges() throws Exception{
         testPhysicalFromFile("limit/limit_exchanges.json");
       }
    +
    +  @Test
    +  public void testPushLimitPastUnionExchange() throws Exception {
    --- End diff --
    
    I think we should add a simple test with data validation for the LIMIT 
pushdown.  Also include OFFSET + LIMIT.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to