Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/159#issuecomment-143367166
Here's the list of keywords that we need to add to the non-reserved list:
*["EXEC", "JOIN", "WINDOW", "LARGE", "PARTITION", "OLD", "COLUMN"]*.
Given Calcite's
[note](https://github.com/apache/incubator-calcite/blob/master/core/src/main/codegen/templates/Parser.jj#L5114)
about such a list and the
[standard](http://savage.net.au/SQL/sql-2003-2.bnf.html#xref-keywords), I am
against making this change. There are a lot of unit test failures (PARSE ERROR)
in TestWindowFrame and TestWindowFunctions with this change.
@julianhyde What are the implications of adding a keyword to the
non-reserved list (say "JOIN")?
Also the option *"store.parquet.block-size"* has a "-" in it which is not
allowed. So do we are escape the word? Or change the name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
