On Sept. 29, 2015, 6:49 p.m., Venki Korukanti wrote: > > In addition to comment above, can you confirm what will happen if a user > > tries to go to http://drillbit:8047? > > > > We should try to make that experience seamless. Is there a way to do that > > (basically redirect them to https://drillbit:8047) > > > > Beyond those changes, +1
Problem is we can't have two protocols on the same port with support provided by jetty. If we are using the default ports (80 for http and 443 for https) we could have http://drillbit and https://drillbit working. From stackoverflow [1] there is a way to implement by overriding connector and looking at the first byte etc. This depends on some low level details of the protocol and java version. For the above reason and warning displayed for self-signed certifcates by browser, is it better to disable the https by default and provide an option? - Venki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38036/#review101062 ----------------------------------------------------------- On Sept. 1, 2015, 5:57 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38036/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 5:57 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-3725 > https://issues.apache.org/jira/browse/DRILL-3725 > > > Repository: drill-git > > > Description > ------- > > See DRILL-3725 for details. > > > Diffs > ----- > > distribution/src/resources/drill-override-example.conf 805d6e9 > exec/java-exec/pom.xml 601f5ca > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 140e9a8 > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 3862cea > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java > PRE-CREATION > pom.xml 8d4b318 > > Diff: https://reviews.apache.org/r/38036/diff/ > > > Testing > ------- > > Manual testing. Working on adding tests for Web interface (DRILL-2965). > > > Thanks, > > Venki Korukanti > >
