Github user cwestin commented on the pull request:
https://github.com/apache/drill/pull/181#issuecomment-145033096
I tried to make the getBufferSize()-calls-getBufferSizeFor() change that
you suggested, Jason, but it causes a lot of unit test failures, so there must
be something else going on in some places. I want to get this into 1.2, so I've
undone that for now. But I've added the valueCount + 1 you spotted, and also
changed the check to if (valueCount == 0) in
BaseRepeatedValueVector.getBufferSizeFor() -- that was a bug nobody spotted.
Testing with those changes now, will push shortly. It'd be great if one of you
could merge this after that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
