Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/148#discussion_r41718161
--- Diff:
common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java
---
@@ -86,15 +84,9 @@ public void setMemo(String memo) {
this.memo = memo;
}
- public synchronized static Class<?>[] getSubTypes(final DrillConfig
config) {
- final List<String> packages =
-
config.getStringList(CommonConstants.LOGICAL_OPERATOR_SCAN_PACKAGES);
- final Class<?>[] ops =
- PathScanner.scanForImplementationsArr(LogicalOperator.class,
packages);
- final String lineBrokenList =
- ops.length == 0 ? "" : "\n\t- " + Joiner.on("\n\t- ").join(ops);
- logger.debug("Found {} logical operator classes: {}.", ops.length,
- lineBrokenList);
+ public synchronized static Set<Class<? extends LogicalOperator>>
getSubTypes(final ScanResult classpathScan) {
--- End diff --
Does this still need synchronized?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
