Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/190#discussion_r41717967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -255,84 +245,20 @@ private void setRecordCountInContainer() {
}
}
- public void resetBatchBuilder() {
- batchBuilder.close();
- batchBuilder = new MergeJoinBatchBuilder(oContext.getAllocator(),
status);
- }
-
- public void addRightToBatchBuilder() {
- batchBuilder.add(right);
+ @Override
+ public void close() {
+ super.close();
+ leftIterator.close();
+ rightIterator.close();
}
@Override
protected void killIncoming(boolean sendUpstream) {
+ close();
--- End diff --
You shouldn't call close here. I believe that should come from the
FragmentExecutor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
