Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/194#discussion_r41808424
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
@@ -355,17 +353,19 @@ public void generateTestData(int values) { }
@Override
public void clear() {
- valueCount = 0;
- for (ValueVector v : getChildren()) {
+ for (final ValueVector v : getChildren()) {
--- End diff --
the logic in clear() seems duplicating close(). we should directly call
close perhaps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
