Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-147580729
@jaltekruse , the simple fix in this PR seems to break the case of
flatten() used in a regular expression tree, such as flatten(a.b) + 1.
On the dev list, the discussion seems to indicate we still want to keep
support such syntax.
I added a small code trying to make it work again for the above simple
case, on top of your patch. You may take a look at
https://github.com/jinfengni/incubator-drill/tree/3876-fix-flatten-simple-extra-copy.
If you do not like this change, you may come up with something else.
Other than the above issue, your patch looks good to me.
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
