Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/189#issuecomment-149385017
Seems to me this pull request would remove the common subexpression
elimination(CSE) for Project and Filter only; it would not do CSE for other
operators, like Join, Aggregation, Union, etc.
I understand that the Union-type work would highly require CSE in
Project/Filter. But will Union-type work would also require CSE in other
operators?
If this JIRA only targets for Project/Filter, I think it would make sense
to explicitly specify this scope in the JIRA. Otherwise, people would expect
CSE would happen to all Drill's relation operator, which is not true.
Another question I have is : how easy is it to extend this patch to include
CSE support for other operators? I tried to enable CSE for all operators.
Turns out that bunch of unit testcase would fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
