Yeah. Windows...
-- Jacques Nadeau CTO and Co-Founder, Dremio On Thu, Nov 5, 2015 at 1:53 PM, Aditya <[email protected]> wrote: > For some reason, the RAT plugin, correctly, detects sequence files as > "binary" on non-Windows platform. > > AL src/test/resources/logback.xml >> B src/test/resources/sequencefiles/simple.seq >> AL src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java >> > > Bug in RAT plugin I guess. > > On Thu, Nov 5, 2015 at 1:48 PM, Jacques Nadeau <[email protected]> wrote: > >> Yeah, I think that sinks it. Weird how Rat complains only on windows... >> >> Let's take the rest of the business day to test the current candidate to >> make sure that we don't spin extra builds unnecessarily. >> >> thanks, >> Jacques >> >> >> -- >> Jacques Nadeau >> CTO and Co-Founder, Dremio >> >> On Thu, Nov 5, 2015 at 1:24 PM, Aditya <[email protected]> wrote: >> >>> Oh, I thought only master/trunk branch was protected, but now I see the >>> mail from David Nalley. >>> >>> In such case, I propose that the release manager could push the branch >>> to his/her private fork and put the URL/hash in the vote starter thread. >>> >>> The reason I was looking to the commit history to determine if the >>> candidate suffer from DRILL-4040, which, evidently it does. >>> >>> -1 as the build from source is failing. >>> >>> [1] https://issues.apache.org/jira/browse/DRILL-4040 >>> >>> On Thu, Nov 5, 2015 at 1:12 PM, Jacques Nadeau <[email protected]> >>> wrote: >>> >>>> I'm not sure what to do here. INFRA just changed the Git behavior so it >>>> is no longer possible to delete branches. I generally don't like to have >>>> failed branches in a release history (otherwise you get a release branch >>>> with all these maven forward/backwards commits). As such, I would overwrite >>>> candidate branches historically (dropping the failed release commits). >>>> >>>> The commit is here right now: >>>> https://github.com/jacques-n/drill/tree/drill-1.3.0-rc0 >>>> >>>> The parent of 4822068a006aeb251b686d2b51871573c4337e60 >>>> is >>>> 3dedc158f3af8ec8320a9cd336b2798b09cc9a8d (the tip of master) >>>> >>>> >>>> >>>> -- >>>> Jacques Nadeau >>>> CTO and Co-Founder, Dremio >>>> >>>> On Thu, Nov 5, 2015 at 1:01 PM, Aditya <[email protected]> wrote: >>>> >>>>> I am having trouble determining the git commit this release is based >>>>> on as >>>>> I could not find the >>>>> id (4822068a006aeb251b686d2b51871573c4337e60) captured in the >>>>> git.properties bundled in the >>>>> tarballs in the Drill Git repository. >>>>> >>>>> Most likely the last commit is only in your local branch and since >>>>> git.properties captures only the >>>>> last commit, it is impossible to find the parent commit. >>>>> >>>>> Would it make sense to push the release branch? >>>>> >>>>> aditya... >>>>> >>>>> On Wed, Nov 4, 2015 at 11:08 PM, Jacques Nadeau <[email protected]> >>>>> wrote: >>>>> >>>>> > Hey Everybody, >>>>> > >>>>> > I'm happy to propose a new release of Apache Drill, version 1.3.0. >>>>> This is >>>>> > the first release candidate (rc0). It covers a total of ~50 closed >>>>> JIRAs >>>>> > [1]. >>>>> > >>>>> > The tarball artifacts are hosted at [2] and the maven artifacts are >>>>> hosted >>>>> > at [3]. >>>>> > >>>>> > The vote will be open for 72 hours ending at 11PM Pacific, November >>>>> 7, >>>>> > 2015. >>>>> > >>>>> > [ ] +1 >>>>> > [ ] +0 >>>>> > [ ] -1 >>>>> > >>>>> > thanks, >>>>> > Jacques >>>>> > >>>>> > [1] >>>>> > >>>>> > >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12332946 >>>>> > [2] http://people.apache.org/~jacques/apache-drill-1.3.0.rc0/ >>>>> > [3] >>>>> > >>>>> https://repository.apache.org/content/repositories/orgapachedrill-1013/ >>>>> > >>>>> >>>> >>>> >>> >> >
