Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/256#discussion_r44866379
  
    --- Diff: pom.xml ---
    @@ -403,7 +403,7 @@
               <configuration>
                 <argLine>-Xms512m -Xmx3g -Ddrill.exec.http.enabled=false
                   -Ddrill.exec.sys.store.provider.local.write=false
    -              
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransformer.scalar_replacement=on"
    +              
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransformer.scalar_replacement=try"
    --- End diff --
    
    This isn't the change we want. Scalar replacement should be "on" for tests 
but "try" for production. Your change is to move it to "try" for tests. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to